Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disttask: add StepExecFrameworkInfo as an example of Impl access Base #52192

Merged
merged 7 commits into from
Mar 29, 2024
Merged

disttask: add StepExecFrameworkInfo as an example of Impl access Base #52192

merged 7 commits into from
Mar 29, 2024

Conversation

lance6716
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #47006

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2024
@tiprow tiprow
Copy link

tiprow bot commented Mar 28, 2024

Hi @lance6716. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lance6716
fix UT
623ced1 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

/ok-to-test

@ti-chi-bot ti-chi-bot bot added ok-to-test Indicates a PR is ready to be tested. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 28, 2024
@lance6716
Copy link
Contributor Author

/retest

1 similar comment
@purelind
Copy link
Contributor

/retest

@lance6716
fix UT
c0d0c0b 
Signed-off-by: lance6716 <[email protected]>
@purelind
Copy link
Contributor

/test mysql-test

@tiprow tiprow
Copy link

tiprow bot commented Mar 28, 2024

@purelind: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test fast_test_tiprow
  • /test tidb_parser_test

Use /test all to run all jobs.

In response to this:

/test mysql-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 28, 2024
@lance6716
fix build
729a417 
Signed-off-by: lance6716 <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Merging #52192 (c6d63b8) into master (9855a55) will increase coverage by 2.2658%.
Report is 11 commits behind head on master.
The diff coverage is 38.8888%.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #52192        +/-   ##
================================================
+ Coverage   70.6469%   72.9128%   +2.2658%     
================================================
  Files          1489       1493         +4     
  Lines        440012     441526      +1514     
================================================
+ Hits         310855     321929     +11074     
+ Misses       109597      99450     -10147     
- Partials      19560      20147       +587
Flag Coverage Δ
integration 49.1912% <30.0000%> (?)
unit 70.5820% <34.7222%> (+0.1341%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.5828% <ø> (+5.8189%) ⬆️

@lance6716
add more comments
e2549c8 
Signed-off-by: lance6716 <[email protected]>
@lance6716
Copy link
Contributor Author

blocked by uber-go/mock#64

@lance6716
Copy link
Contributor Author

/cc @Benjamin2037 @YuJuncen

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 29, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-28 08:12:52.570479859 +0000 UTC m=+2141999.592726247: ☑️ agreed by D3Hunter.
  • 2024-03-29 02:04:41.638160612 +0000 UTC m=+2206308.660407000: ☑️ agreed by ywqzzy.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, YuJuncen, ywqzzy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 29, 2024
@lance6716
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit ad63eb8 into pingcap:master Mar 29, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

@Benjamin2037 Benjamin2037 Awaiting requested review from Benjamin2037

Assignees
No one assigned
Labels
approved lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lance6716 @purelind @D3Hunter @ywqzzy @YuJuncen